Changeset 1199


Ignore:
Timestamp:
9/28/2009 7:33:09 AM (4 years ago)
Author:
lowjoel
Message:

Silence a few FxCop? warnings.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/eraser6/Eraser.fxcop

    r1158 r1199  
    5656  <Settings /> 
    5757 </Rules> 
    58  <FxCopReport Version="1.36" LastAnalysis="2009-07-03 10:46:36Z"> 
     58 <FxCopReport Version="1.36" LastAnalysis="2009-09-28 06:30:14Z"> 
    5959  <Namespaces> 
    6060   <Namespace Name="Eraser.Unlocker"> 
    … …  
    313313            <Messages> 
    314314             <Message TypeName="DoNotCallOverridableMethodsInConstructors" Category="Microsoft.Usage" CheckId="CA2214" Created="2009-05-01 03:14:45Z"> 
    315               <Issue Path="D:\Development\Projects\Eraser\Eraser.Manager" File="DirectExecutor.cs" Line="1048"> 
     315              <Issue Path="D:\Development\Projects\Eraser\Eraser.Manager" File="DirectExecutor.cs" Line="848"> 
    316316               <Item>'DirectExecutor.DirectExecutor()'</Item> 
    317317               <Item>&#xD;&#xA;&#xD;&#xA;DirectExecutor..ctor()&#xD;&#xA;Executor.set_TaskAdded(EventHandler&lt;TaskEventArgs&gt;):Void&#xD;&#xA;Executor.set_TaskDeleted(EventHandler&lt;TaskEventArgs&gt;):Void&#xD;&#xA;Executor.set_Tasks(ExecutorTasksCollection):Void</Item> 
    … …  
    323323            <Messages> 
    324324             <Message TypeName="DoNotCastUnnecessarily" Category="Microsoft.Performance" CheckId="CA1800" Created="2009-05-01 03:14:45Z"> 
    325               <Issue Name="Parameter" Path="D:\Development\Projects\Eraser\Eraser.Manager" File="DirectExecutor.cs" Line="976"> 
     325              <Issue Name="Parameter" Path="D:\Development\Projects\Eraser\Eraser.Manager" File="DirectExecutor.cs" Line="791"> 
    326326               <Item>'target'</Item> 
    327327               <Item>'FolderTarget'</Item> 
    … …  
    335335            <Messages> 
    336336             <Message TypeName="DoNotCatchGeneralExceptionTypes" Category="Microsoft.Design" CheckId="CA1031" Status="Excluded" Created="2009-05-01 03:14:45Z"> 
    337               <Issue Path="D:\Development\Projects\Eraser\Eraser.Manager" File="DirectExecutor.cs" Line="267"> 
     337              <Issue Path="D:\Development\Projects\Eraser\Eraser.Manager" File="DirectExecutor.cs" Line="271"> 
    338338               <Item>'DirectExecutor.Main()'</Item> 
    339339               <Item>'Exception'</Item> 
    340340              </Issue> 
    341               <Issue Path="D:\Development\Projects\Eraser\Eraser.Manager" File="DirectExecutor.cs" Line="276"> 
     341              <Issue Path="D:\Development\Projects\Eraser\Eraser.Manager" File="DirectExecutor.cs" Line="284"> 
    342342               <Item>'DirectExecutor.Main()'</Item> 
    343343               <Item>'Exception'</Item> 
    … …  
    369369         <Type Name="ErasureMethod"> 
    370370          <Members> 
    371            <Member Name="#Erase(System.IO.Stream,System.Int64,Eraser.Manager.Prng,Eraser.Manager.EraserMethodProgressFunction)"> 
    372             <Messages> 
    373              <Message Id="Erase" TypeName="IdentifiersShouldNotMatchKeywords" Category="Microsoft.Naming" CheckId="CA1716" Status="Excluded" Created="2009-05-01 04:19:08Z"> 
     371           <Member Name="#Erase(System.IO.Stream,System.Int64,Eraser.Manager.Prng,Eraser.Manager.ErasureMethodProgressFunction)"> 
     372            <Messages> 
     373             <Message Id="Erase" TypeName="IdentifiersShouldNotMatchKeywords" Category="Microsoft.Naming" CheckId="CA1716" Status="Excluded" Created="2009-09-28 06:25:17Z"> 
    374374              <Issue Name="Member"> 
    375                <Item>'ErasureMethod.Erase(Stream, long, Prng, EraserMethodProgressFunction)'</Item> 
     375               <Item>'ErasureMethod.Erase(Stream, long, Prng, ErasureMethodProgressFunction)'</Item> 
    376376               <Item>Erase</Item> 
    377377              </Issue> 
    378378              <Notes> 
    379379               <User Name="Joel"> 
    380                 <Note Id="1" /> 
     380                <Note Id="19" /> 
    381381               </User> 
    382382              </Notes> 
    … …  
    412412              <Messages> 
    413413               <Message TypeName="DoNotRaiseExceptionsInUnexpectedLocations" Category="Microsoft.Design" CheckId="CA1065" Created="2009-07-03 06:55:12Z" FixCategory="Breaking"> 
    414                 <Issue Name="PropertyGetter" Level="Warning" Path="D:\Development\Projects\Eraser\Eraser.Manager" File="Task.cs" Line="296"> 
     414                <Issue Name="PropertyGetter" Level="Warning" Path="D:\Development\Projects\Eraser\Eraser.Manager" File="Task.cs" Line="309"> 
    415415                 <Item>'ErasureTarget.Method.get()'</Item> 
    416416                 <Item>'NotImplementedException'</Item> 
    … …  
    462462            <Messages> 
    463463             <Message Id="1#" TypeName="AvoidOutParameters" Category="Microsoft.Design" CheckId="CA1021" Created="2009-05-01 03:23:16Z"> 
    464               <Issue Path="D:\Development\Projects\Eraser\Eraser.Manager" File="Task.cs" Line="384"> 
     464              <Issue Path="D:\Development\Projects\Eraser\Eraser.Manager" File="Task.cs" Line="397"> 
    465465               <Item>'totalSize'</Item> 
    466466              </Issue> 
    … …  
    492492            <Messages> 
    493493             <Message TypeName="CollectionPropertiesShouldBeReadOnly" Category="Microsoft.Usage" CheckId="CA2227" Created="2009-05-01 03:14:45Z"> 
    494               <Issue Path="D:\Development\Projects\Eraser\Eraser.Manager" File="Settings.cs" Line="339"> 
     494              <Issue Path="D:\Development\Projects\Eraser\Eraser.Manager" File="Settings.cs" Line="319"> 
    495495               <Item>'ManagerSettings.PlausibleDeniabilityFiles'</Item> 
    496496              </Issue> 
    497497             </Message> 
    498498             <Message TypeName="DoNotExposeGenericLists" Category="Microsoft.Design" CheckId="CA1002" Created="2009-05-01 03:14:45Z"> 
    499               <Issue Path="D:\Development\Projects\Eraser\Eraser.Manager" File="Settings.cs" Line="339"> 
     499              <Issue Path="D:\Development\Projects\Eraser\Eraser.Manager" File="Settings.cs" Line="319"> 
    500500               <Item>'List&lt;string&gt;'</Item> 
    501501               <Item>'ManagerSettings.PlausibleDeniabilityFiles'</Item> 
    … …  
    507507            <Messages> 
    508508             <Message TypeName="CollectionPropertiesShouldBeReadOnly" Category="Microsoft.Usage" CheckId="CA2227" Created="2009-05-01 03:14:45Z"> 
    509               <Issue Path="D:\Development\Projects\Eraser\Eraser.Manager" File="Settings.cs" Line="472"> 
     509              <Issue Path="D:\Development\Projects\Eraser\Eraser.Manager" File="Settings.cs" Line="452"> 
    510510               <Item>'ManagerSettings.PluginApprovals'</Item> 
    511511              </Issue> 
    … …  
    553553         <Type Name="Schedule"> 
    554554          <Members> 
     555           <Member Name="#RunManually"> 
     556            <Messages> 
     557             <Message TypeName="DoNotDeclareReadOnlyMutableReferenceTypes" Category="Microsoft.Security" CheckId="CA2104" Status="Excluded" Created="2009-07-06 08:09:06Z"> 
     558              <Issue> 
     559               <Item>'Schedule.RunManually'</Item> 
     560               <Item>'Schedule'</Item> 
     561              </Issue> 
     562              <Notes> 
     563               <User Name="Joel"> 
     564                <Note Id="18" /> 
     565               </User> 
     566              </Notes> 
     567             </Message> 
     568            </Messages> 
     569           </Member> 
    555570           <Member Name="#RunNow"> 
    556571            <Messages> 
    … …  
    614629           <Member Name="#Close()"> 
    615630            <Messages> 
    616              <Message Id="&lt;Module&gt;.CloseHandle(System.Void*)" TypeName="DoNotIgnoreMethodResults" Category="Microsoft.Usage" CheckId="CA1806" Created="2009-06-02 07:31:56Z"> 
     631             <Message Id="&lt;Module&gt;.CloseHandle(System.Void*)" TypeName="DoNotIgnoreMethodResults" Category="Microsoft.Usage" CheckId="CA1806" Status="Excluded" Created="2009-06-02 07:31:56Z"> 
    617632              <Issue Name="HResultOrErrorCode" Path="d:\development\projects\eraser\eraser.unlocker" File="eraser.unlocker.cpp" Line="133"> 
    618633               <Item>'OpenHandle.Close()'</Item> 
    … …  
    623638               <Item>'&lt;Module&gt;.CloseHandle(void*)'</Item> 
    624639              </Issue> 
     640              <Notes> 
     641               <User Name="Joel"> 
     642                <Note Id="21" /> 
     643               </User> 
     644              </Notes> 
    625645             </Message> 
    626646             <Message Id="&lt;Module&gt;.DuplicateHandle(System.Void*,System.Void*,System.Void*,System.Void**,optional(System.Runtime.CompilerServices.IsLong) System.UInt32,System.Int32,optional(System.Runtime.CompilerServices.IsLong) System.UInt32)" TypeName="DoNotIgnoreMethodResults" Category="Microsoft.Usage" CheckId="CA1806" Status="Excluded" Created="2009-06-02 07:31:56Z"> 
    … …  
    639659           <Member Name="#ResolveHandlePath(System.IntPtr,System.Int32)"> 
    640660            <Messages> 
    641              <Message Id="&lt;Module&gt;.CloseHandle(System.Void*)" TypeName="DoNotIgnoreMethodResults" Category="Microsoft.Usage" CheckId="CA1806" Created="2009-06-02 07:31:56Z"> 
    642               <Issue Name="HResultOrErrorCode" Path="d:\development\projects\eraser\eraser.unlocker" File="eraser.unlocker.cpp" Line="88"> 
    643                <Item>'OpenHandle.ResolveHandlePath(IntPtr, int)'</Item> 
    644                <Item>'&lt;Module&gt;.CloseHandle(void*)'</Item> 
    645               </Issue> 
    646               <Issue Name="HResultOrErrorCode" Path="d:\development\projects\eraser\eraser.unlocker" File="eraser.unlocker.cpp" Line="107"> 
    647                <Item>'OpenHandle.ResolveHandlePath(IntPtr, int)'</Item> 
    648                <Item>'&lt;Module&gt;.CloseHandle(void*)'</Item> 
    649               </Issue> 
    650              </Message> 
    651661             <Message Id="&lt;Module&gt;.ReleaseSemaphore(System.Void*,optional(System.Runtime.CompilerServices.IsLong) System.Int32,System.optional(IsLong) Int32*)" TypeName="DoNotIgnoreMethodResults" Category="Microsoft.Usage" CheckId="CA1806" Created="2009-06-02 07:31:56Z"> 
    652662              <Issue Name="HResultOrErrorCode" Path="d:\development\projects\eraser\eraser.unlocker" File="eraser.unlocker.cpp" Line="97"> 
    … …  
    654664               <Item>'&lt;Module&gt;.ReleaseSemaphore(void*, int, int*)'</Item> 
    655665              </Issue> 
     666             </Message> 
     667             <Message Id="&lt;Module&gt;.CloseHandle(System.Void*)" TypeName="DoNotIgnoreMethodResults" Category="Microsoft.Usage" CheckId="CA1806" Status="Excluded" Created="2009-06-02 07:31:56Z"> 
     668              <Issue Name="HResultOrErrorCode" Path="d:\development\projects\eraser\eraser.unlocker" File="eraser.unlocker.cpp" Line="88"> 
     669               <Item>'OpenHandle.ResolveHandlePath(IntPtr, int)'</Item> 
     670               <Item>'&lt;Module&gt;.CloseHandle(void*)'</Item> 
     671              </Issue> 
     672              <Issue Name="HResultOrErrorCode" Path="d:\development\projects\eraser\eraser.unlocker" File="eraser.unlocker.cpp" Line="107"> 
     673               <Item>'OpenHandle.ResolveHandlePath(IntPtr, int)'</Item> 
     674               <Item>'&lt;Module&gt;.CloseHandle(void*)'</Item> 
     675              </Issue> 
     676              <Notes> 
     677               <User Name="Joel"> 
     678                <Note Id="20" /> 
     679               </User> 
     680              </Notes> 
    656681             </Message> 
    657682             <Message Id="&lt;Module&gt;.DuplicateHandle(System.Void*,System.Void*,System.Void*,System.Void**,optional(System.Runtime.CompilerServices.IsLong) System.UInt32,System.Int32,optional(System.Runtime.CompilerServices.IsLong) System.UInt32)" TypeName="DoNotIgnoreMethodResults" Category="Microsoft.Usage" CheckId="CA1806" Status="Excluded" Created="2009-06-02 07:31:56Z"> 
    … …  
    766791   <User Name="Joel"> 
    767792    <Note Id="0" Modified="2009-06-02 07:18:16Z">All fields are relevant</Note> 
    768     <Note Id="1" Modified="2009-06-02 07:18:44Z">No better alternative</Note> 
    769793    <Note Id="2" Modified="2009-06-02 07:18:57Z">Build metadata</Note> 
    770794    <Note Id="3" Modified="2009-06-02 07:19:19Z">Used to force creation of window handle</Note> 
    … …  
    783807    <Note Id="16" Modified="2009-06-02 07:36:03Z">Unlocker is our assembly name, hence a proper noun</Note> 
    784808    <Note Id="17" Modified="2009-07-03 07:02:50Z">Can't think of a better exception to use</Note> 
     809    <Note Id="18" Modified="2009-07-06 08:09:47Z">Already is immutable</Note> 
     810    <Note Id="19" Modified="2009-09-28 06:26:12Z">There seems to be no suitable alternative.</Note> 
     811    <Note Id="20" Modified="2009-09-28 06:28:24Z">If CloseHandle fails, there's nothing we can do.</Note> 
     812    <Note Id="21" Modified="2009-09-28 06:29:02Z">If CloseHandle fails we cannot do anything to recover our state.</Note> 
    785813   </User> 
    786814  </Notes> 
Note: See TracChangeset for help on using the changeset viewer.