Changeset 1446


Ignore:
Timestamp:
1/4/2010 10:17:05 AM (5 years ago)
Author:
lowjoel
Message:

Do not explicitly allow or disallow a plugin based on whether the plugin is checked in the plugin settings list view. This is because signed plugins load automatically; if the signature changes or if root certificates change the plugin may then be a valid signed assembly. This also fixes the "double error message on startup" where users are greeted with the "invalid unused space and file erasure methods as well as PRNG" will be given the "plugins will only be loaded on restart" message (which makes no sense to the user)

Location:
trunk/eraser6
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/eraser6/Eraser.Manager/Plugins.cs

    r1360 r1446  
    349349 
    350350        /// <summary> 
    351         /// Gets the IPlugin interface which the plugin exposed. 
     351        /// Gets the IPlugin interface which the plugin exposed. This may be null 
     352        /// if the plugin was not loaded. 
    352353        /// </summary> 
    353354        public IPlugin Plugin { get; internal set; } 
     355 
     356        /// <summary> 
     357        /// Gets whether this particular plugin is currently loaded in memory. 
     358        /// </summary> 
     359        public bool Loaded 
     360        { 
     361            get { return Plugin != null; } 
     362        } 
    354363 
    355364        private Assembly assembly; 
  • trunk/eraser6/Eraser/SettingsPanel.cs

    r1360 r1446  
    353353                if (!pluginApprovals.ContainsKey(guid)) 
    354354                { 
    355                     pluginApprovals.Add(guid, item.Checked); 
    356                     pluginApprovalsChanged = true; 
     355                    if (plugin.Plugin.Loaded != item.Checked) 
     356                    { 
     357                        pluginApprovals.Add(guid, item.Checked); 
     358                        pluginApprovalsChanged = true; 
     359                    } 
    357360                } 
    358361                else if (pluginApprovals[guid] != item.Checked) 
Note: See TracChangeset for help on using the changeset viewer.