Changeset 1446 for trunk/eraser6

Timestamp:

1/4/2010 10:17:05 AM (3 years ago)

Author:

lowjoel

Message:

Do not explicitly allow or disallow a plugin based on whether the plugin is checked in the plugin settings list view. This is because signed plugins load automatically; if the signature changes or if root certificates change the plugin may then be a valid signed assembly. This also fixes the "double error message on startup" where users are greeted with the "invalid unused space and file erasure methods as well as PRNG" will be given the "plugins will only be loaded on restart" message (which makes no sense to the user)

Location:

trunk/eraser6

Files:

• Eraser.Manager/Plugins.cs (modified) (1 diff)
• Eraser/SettingsPanel.cs (modified) (1 diff)

trunk/eraser6/Eraser.Manager/Plugins.cs

@@ -349 +349 @@
 
         /// <summary>
-        /// Gets the IPlugin interface which the plugin exposed.
+        /// Gets the IPlugin interface which the plugin exposed. This may be null
+        /// if the plugin was not loaded.
         /// </summary>
         public IPlugin Plugin { get; internal set; }
+
+        /// <summary>
+        /// Gets whether this particular plugin is currently loaded in memory.
+        /// </summary>
+        public bool Loaded
+        {
+            get { return Plugin != null; }
+        }
 
         private Assembly assembly;

trunk/eraser6/Eraser/SettingsPanel.cs

@@ -353 +353 @@
                 if (!pluginApprovals.ContainsKey(guid))
                 {
-                    pluginApprovals.Add(guid, item.Checked);
-                    pluginApprovalsChanged = true;
+                    if (plugin.Plugin.Loaded != item.Checked)
+                    {
+                        pluginApprovals.Add(guid, item.Checked);
+                        pluginApprovalsChanged = true;
+                    }
                 }
                 else if (pluginApprovals[guid] != item.Checked)