Changeset 1590

Timestamp:

1/19/2010 2:43:39 AM (3 years ago)

Author:

lowjoel

Message:

Fixed warning CA1800: Microsoft.Performance : 'control', a parameter, is cast to type multiple times in method 'Theming.ApplyTheme?(Control)'.

File:

• branches/eraser6/CodeReview/Eraser.Util/Theming.cs (modified) (1 diff)

branches/eraser6/CodeReview/Eraser.Util/Theming.cs

@@ -57 +57 @@
         public static void ApplyTheme(Control control)
         {
-            if (control is ContainerControl)
-                ((ContainerControl)control).Font = SystemFonts.MessageBoxFont;
+            ContainerControl container = control as ContainerControl;
+            ButtonBase button = control as ButtonBase;
+            ListView listview = control as ListView;
+            ToolStrip toolstrip = control as ToolStrip;
+
+            if (container != null)
+                container.Font = SystemFonts.MessageBoxFont;
             else if (control.Font != SystemFonts.MessageBoxFont)
                 control.Font = new Font(SystemFonts.MessageBoxFont.FontFamily,
                     control.Font.Size, control.Font.Style);
 
-            if (control is ButtonBase)
-                ApplyTheme((ButtonBase)control);
-            else if (control is ListView)
-                ApplyTheme((ListView)control);
-            else if (control is ToolStrip)
-                ApplyTheme((ToolStrip)control);
+            if (button != null)
+                ApplyTheme(button);
+            else if (listview != null)
+                ApplyTheme(listview);
+            else if (toolstrip != null)
+                ApplyTheme(toolstrip);
 
             if (control.ContextMenuStrip != null)