Changeset 1600

Timestamp:

1/19/2010 3:56:06 AM (3 years ago)

Author:

lowjoel

Message:

These warnings generated by FxCop? can be suppressed as the code has been verified and excluded.

Location:

branches/eraser6/CodeReview/Eraser.Util

Files:

• ConsoleWindow.cs (modified) (1 diff)
• Localisation.cs (modified) (3 diffs)
• Theming.cs (modified) (1 diff)

branches/eraser6/CodeReview/Eraser.Util/ConsoleWindow.cs

@@ -50 +50 @@
         }
 
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "disposing")]
         private void Dispose(bool disposing)
         {

branches/eraser6/CodeReview/Eraser.Util/Localisation.cs

@@ -38 +38 @@
     /// call S._(string) or S._(string, object) for plurals
     /// </summary>
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1704:IdentifiersShouldBeSpelledCorrectly", MessageId = "S")]
     public static class S
     {
@@ -45 +46 @@
         /// <param name="str">The string to localise.</param>
         /// <returns>A localised string, or str if no localisation exists.</returns>
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1707:IdentifiersShouldNotContainUnderscores")]
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1704:IdentifiersShouldBeSpelledCorrectly", MessageId = "_")]
         public static string _(string text)
         {
@@ -59 +62 @@
         /// <returns>The formatted and localised string.</returns>
         /// <remarks>The localised string is retrieved before formatting.</remarks>
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1707:IdentifiersShouldNotContainUnderscores")]
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1704:IdentifiersShouldBeSpelledCorrectly", MessageId = "_")]
         public static string _(string text, params object[] args)
         {

branches/eraser6/CodeReview/Eraser.Util/Theming.cs

@@ -200 +200 @@
                 if (Instance != null)
                     throw new InvalidOperationException("Only one instance of the " +
-                        "ThemeMessageFilter can exist at any one time.");
+                        "theme-change message filter can exist at any one time.");
 
                 Instance = this;