Changeset 1639 for branches/eraser6/6.0

Timestamp:

1/22/2010 5:54:47 AM (2 years ago)

Author:

lowjoel

Message:

Fixed race condition when two instance of Eraser are started simultaneously. The first instance would have created the pipe which listens for commands, then creates the program window. The second instance would find the mutex created and connect to the pipe from the first instance. The first instance broadcasts the OnNextInstance? event, but the main thread is still in the constructor of the MainForm?. The program then has a NullReferenceException?. The new behaviour is to initialise the main window before the pipe listening for new instances are created. This also allows the OnInitInstance? event to abort the startup of the program.

File:

• branches/eraser6/6.0/Eraser/Program.cs (modified) (1 diff)

branches/eraser6/6.0/Eraser/Program.cs

@@ -335 +335 @@
                 try
                 {
-                    //Create the pipe server which will handle connections to us
-                    pipeServer = new Thread(ServerMain);
-                    pipeServer.Start();
-
                     //Initialise and run the program.
                     bool ShowMainForm = OnInitInstance(this);
                     if (MainForm == null)
                         return false;
+
+                    //Create the pipe server which will handle connections to us
+                    pipeServer = new Thread(ServerMain);
+                    pipeServer.Start();
 
                     //Handle the exit instance event. This will occur when the main form