Changeset 1641

Timestamp:

1/22/2010 6:26:44 AM (3 years ago)

Author:

lowjoel

Message:

Fixed crash when user clicks on About dialog links but there was an error starting the process. This results in Process.Start throwing a Win32Exception which we now catch and show the error to the user.

Location:

branches/eraser6/6.0/Eraser

Files:

• AboutForm.cs (modified) (1 diff)
• Strings.NL.resx (modified) (1 diff)
• Strings.en.resx (modified) (1 diff)
• Strings.it.resx (modified) (1 diff)
• Strings.resx (modified) (1 diff)

branches/eraser6/6.0/Eraser/AboutForm.cs

@@ -190 +190 @@
         {
             Point cursorPos = PointToClient(Cursor.Position);
-            if (WebsiteRect.IntersectsWith(new Rectangle(cursorPos, new Size(1, 1))))
-                Process.Start("http://eraser.heidi.ie/");
-            else if (DonateRect.IntersectsWith(new Rectangle(cursorPos, new Size(1, 1))))
-                Process.Start("https://euro.swreg.org/cgi-bin/s.cgi?r=1&s=80181&db_key=1512312&x=0&lang=&lnk=");
-            else if ((DateTime.Now - mouseDownTime < mouseSpeedUpSpan))
-                //Dismiss the dialog.
-                Close();
+            try
+            {
+                if (WebsiteRect.IntersectsWith(new Rectangle(cursorPos, new Size(1, 1))))
+                    Process.Start("http://eraser.heidi.ie/");
+                else if (DonateRect.IntersectsWith(new Rectangle(cursorPos, new Size(1, 1))))
+                    Process.Start("https://euro.swreg.org/cgi-bin/s.cgi?r=1&s=80181&db_key=1512312&x=0&lang=&lnk=");
+                else if ((DateTime.Now - mouseDownTime < mouseSpeedUpSpan))
+                    //Dismiss the dialog.
+                    Close();
+            }
+            catch (Win32Exception ex)
+            {
+                //We've got an error executing the the browser to pass the links: show an error
+                //to the user.
+                MessageBox.Show(S._("Could not open the required web page. The error returned " +
+                    "was: {0}", ex.Message), S._("Eraser"), MessageBoxButtons.OK,
+                    MessageBoxIcon.Error, MessageBoxDefaultButton.Button1,
+                    S.IsRightToLeft(null) ? MessageBoxOptions.RtlReading : 0);
+            }
         }
 

branches/eraser6/6.0/Eraser/Strings.NL.resx

@@ -139 +139 @@
     <value>(Untranslated)</value>
   </data>
+  <data name="Could not open the required web page. The error returned was: {0}" xml:space="preserve">
+    <value>(Untranslated)</value>
+  </data>
   <data name="Session: {0:F}" xml:space="preserve">
     <value>(Untranslated)</value>

branches/eraser6/6.0/Eraser/Strings.en.resx

@@ -139 +139 @@
     <value>Please help us to continue developing Eraser - donate some coffee!</value>
   </data>
+  <data name="Could not open the required web page. The error returned was: {0}" xml:space="preserve">
+    <value>Could not open the required web page. The error returned was: {0}</value>
+  </data>
   <data name="Session: {0:F}" xml:space="preserve">
     <value>Session: {0:F}</value>

branches/eraser6/6.0/Eraser/Strings.it.resx

@@ -139 +139 @@
     <value>Aiutateci a continuare lo sviluppo di Eraser - offriteci un caffè!</value>
   </data>
+  <data name="Could not open the required web page. The error returned was: {0}" xml:space="preserve">
+    <value>(Untranslated)</value>
+  </data>
   <data name="Session: {0:F}" xml:space="preserve">
     <value>Sessione: {0:F}</value>

branches/eraser6/6.0/Eraser/Strings.resx

@@ -139 +139 @@
     <value>Please help us to continue developing Eraser - donate some coffee!</value>
   </data>
+  <data name="Could not open the required web page. The error returned was: {0}" xml:space="preserve">
+    <value>Could not open the required web page. The error returned was: {0}</value>
+  </data>
   <data name="Session: {0:F}" xml:space="preserve">
     <value>Session: {0:F}</value>