Changeset 1662 for trunk/eraser6/Eraser.Manager/Task.cs

Timestamp:

1/25/2010 3:01:45 AM (3 years ago)

Author:

lowjoel

Message:

Fixed regression in r1102: the check on Exists ensures that the DirectoryNotFoundException? will not be raised -- however, it doesn't guard against UnauthorizedAccessException?, so we should be guarding against that instead.

File:

• trunk/eraser6/Eraser.Manager/Task.cs (modified) (1 diff)

trunk/eraser6/Eraser.Manager/Task.cs

@@ -718 +718 @@
             if (info.Exists)
             {
-                foreach (DirectoryInfo dir in info.GetDirectories())
-                    try
-                    {
+                try
+                {
+                    foreach (DirectoryInfo dir in info.GetDirectories())
                         result.AddRange(GetFiles(dir));
-                    }
-                    catch (DirectoryNotFoundException e)
-                    {
-                        //Ignore, but log.
-                        Task.Log.LastSessionEntries.Add(new LogEntry(S._("Could not erase {0} because {1}",
-                            dir.FullName, e.Message), LogLevel.Error));
-                    }
-
-                if (IncludeMask.Length == 0)
-                    result.AddRange(info.GetFiles());
-                else
-                    result.AddRange(info.GetFiles(IncludeMask, SearchOption.TopDirectoryOnly));
+
+                    if (IncludeMask.Length == 0)
+                        result.AddRange(info.GetFiles());
+                    else
+                        result.AddRange(info.GetFiles(IncludeMask, SearchOption.TopDirectoryOnly));
+                }
+                catch (UnauthorizedAccessException e)
+                {
+                    Task.Log.LastSessionEntries.Add(new LogEntry(S._("Could not erase files and " +
+                        "subfolders in {0} because {1}", info.FullName, e.Message), LogLevel.Error));
+                }
             }