Changeset 1765 for branches/eraser6/CodeReview/Eraser.Manager/Task.cs

Timestamp:

2/8/2010 6:44:59 AM (2 years ago)

Author:

lowjoel

Message:

Removed the TaskProcessing? and TaskProcessed? events in Executor which duplicate the TaskStarted? and TaskFinished? events in Task. The TaskEventArgs? class can't disappear just yet as the TaskAdded? and TaskDeleted? events still need them (the sender is not the task, it's the executor) Addresses #275: Code Review

File:

• branches/eraser6/CodeReview/Eraser.Manager/Task.cs (modified) (5 diffs)

branches/eraser6/CodeReview/Eraser.Manager/Task.cs

@@ -226 +226 @@
         /// The task has been edited.
         /// </summary>
-        public EventHandler<TaskEventArgs> TaskEdited { get; set; }
+        public EventHandler TaskEdited { get; set; }
 
         /// <summary>
         /// The start of the execution of a task.
         /// </summary>
-        public EventHandler<TaskEventArgs> TaskStarted { get; set; }
+        public EventHandler TaskStarted { get; set; }
 
         /// <summary>
@@ -241 +241 @@
         /// The completion of the execution of a task.
         /// </summary>
-        public EventHandler<TaskEventArgs> TaskFinished { get; set; }
+        public EventHandler TaskFinished { get; set; }
 
         /// <summary>
@@ -249 +249 @@
         {
             if (TaskEdited != null)
-                TaskEdited(this, new TaskEventArgs(this));
+                TaskEdited(this, EventArgs.Empty);
         }
 
@@ -255 +255 @@
         /// Broadcasts the task execution start event.
         /// </summary>
-        /// <param name="e"></param>
-        internal void OnTaskStarted(TaskEventArgs e)
+        internal void OnTaskStarted()
         {
             if (TaskStarted != null)
-                TaskStarted(this, e);
+                TaskStarted(this, EventArgs.Empty);
             Executing = true;
             Progress = new SteppedProgressManager();
@@ -294 +293 @@
         /// Broadcasts the task execution completion event.
         /// </summary>
-        /// <param name="e"></param>
-        internal void OnTaskFinished(TaskEventArgs e)
+        internal void OnTaskFinished()
         {
             if (TaskFinished != null)
-                TaskFinished(this, e);
+                TaskFinished(this, EventArgs.Empty);
             Executing = false;
             Progress = null;