Changeset 1765 for branches/eraser6/CodeReview/Eraser/ProgressForm.cs

Timestamp:

2/8/2010 6:44:59 AM (2 years ago)

Author:

lowjoel

Message:

Removed the TaskProcessing? and TaskProcessed? events in Executor which duplicate the TaskStarted? and TaskFinished? events in Task. The TaskEventArgs? class can't disappear just yet as the TaskAdded? and TaskDeleted? events still need them (the sender is not the task, it's the executor) Addresses #275: Code Review

File:

• branches/eraser6/CodeReview/Eraser/ProgressForm.cs (modified) (3 diffs)

branches/eraser6/CodeReview/Eraser/ProgressForm.cs

@@ -89 +89 @@
         }
 
-        private void task_TaskFinished(object sender, TaskEventArgs e)
+        private void task_TaskFinished(object sender, EventArgs e)
         {
             if (IsDisposed || !IsHandleCreated)
@@ -95 +95 @@
             if (InvokeRequired)
             {
-                Invoke((EventHandler<TaskEventArgs>)task_TaskFinished, sender, e);
+                Invoke((EventHandler)task_TaskFinished, sender, e);
                 return;
             }
 
             //Update the UI. Set everything to 100%
+            Task task = (Task)sender;
             timeLeft.Text = item.Text = pass.Text = string.Empty;
             overallProgressLbl.Text = S._("Total: {0,2:#0.00%}", 1.0);
@@ -109 +110 @@
             //Inform the user on the status of the task.
             LogLevel highestLevel = LogLevel.Information;
-            LogEntryCollection entries = e.Task.Log.LastSessionEntries;
+            LogEntryCollection entries = task.Log.LastSessionEntries;
             foreach (LogEntry log in entries)
                 if (log.Level > highestLevel)