Changeset 1767 for branches/eraser6/CodeReview/Eraser.Manager/Method.cs

Timestamp:

2/8/2010 7:09:55 AM (2 years ago)

Author:

lowjoel

Message:

Do not localise exceptions which aren't meant to be seen by the user. User-visible exceptions will be dealt with in a separate ticket. Do not throw exceptions to indicate handleable errors (notably, when erasing unused space without administrator permissions) Addresses #275: Code Review

File:

• branches/eraser6/CodeReview/Eraser.Manager/Method.cs (modified) (4 diffs)

branches/eraser6/CodeReview/Eraser.Manager/Method.cs

@@ -378 +378 @@
             public override long CalculateEraseDataSize(ICollection<string> paths, long targetSize)
             {
-                throw new InvalidOperationException(S._("The DefaultMethod class should never " +
-                    "be used and should instead be replaced before execution!"));
+                throw new InvalidOperationException("The DefaultMethod class should never " +
+                    "be used and should instead be replaced before execution!");
             }
 
@@ -385 +385 @@
                 ErasureMethodProgressFunction callback)
             {
-                throw new InvalidOperationException(S._("The DefaultMethod class should never " +
-                    "be used and should instead be replaced before execution!"));
+                throw new InvalidOperationException("The DefaultMethod class should never " +
+                    "be used and should instead be replaced before execution!");
             }
         }
@@ -473 +473 @@
             //Check for a valid constructor.
             if (ctor == null)
-                throw new ArgumentException(S._("Registered erasure methods must contain " +
+                throw new ArgumentException("Registered erasure methods must contain " +
                     "a parameterless constructor that is called whenever clients request " +
                     "for an instance of the method. If a constructor requires parameters, " +
-                    "specify it in the parameters parameter."));
+                    "specify it in the parameters parameter.");
 
             //Insert the entry
@@ -498 +498 @@
         {
             if (!ManagerLibrary.Instance.ErasureMethodManager.methods.ContainsKey(value))
-                throw new ArgumentException(S._("The GUID of the erasure method to remove " +
-                    "refers to an invalid erasure method."));
+                throw new ArgumentException("The GUID of the erasure method to remove " +
+                    "refers to an invalid erasure method.");
 
             ManagerLibrary.Instance.ErasureMethodManager.methods.Remove(value);