Changeset 1767 for branches/eraser6/CodeReview/Eraser.Manager/Schedule.cs

Timestamp:

2/8/2010 7:09:55 AM (2 years ago)

Author:

lowjoel

Message:

Do not localise exceptions which aren't meant to be seen by the user. User-visible exceptions will be dealt with in a separate ticket. Do not throw exceptions to indicate handleable errors (notably, when erasing unused space without administrator permissions) Addresses #275: Code Review

File:

• branches/eraser6/CodeReview/Eraser.Manager/Schedule.cs (modified) (4 diffs)

branches/eraser6/CodeReview/Eraser.Manager/Schedule.cs

@@ -273 +273 @@
                 if (ScheduleType != RecurringScheduleUnit.Daily && ScheduleType != RecurringScheduleUnit.Weekly &&
                     ScheduleType != RecurringScheduleUnit.Monthly)
-                    throw new InvalidOperationException(S._("The ScheduleUnit of the schedule " +
-                        "does not require a frequency value, this field would contain garbage."));
+                    throw new InvalidOperationException("The ScheduleUnit of the schedule " +
+                        "does not require a frequency value, this field would contain garbage.");
 
                 return frequency;
@@ -314 +314 @@
             {
                 if (ScheduleType != RecurringScheduleUnit.Weekly)
-                    throw new InvalidOperationException(S._("The ScheduleUnit of the schedule " +
-                        "does not require the WeeklySchedule value, this field would contain garbage"));
+                    throw new InvalidOperationException("The ScheduleUnit of the schedule " +
+                        "does not require the WeeklySchedule value, this field would contain garbage");
 
                 return weeklySchedule;
@@ -340 +340 @@
             {
                 if (ScheduleType != RecurringScheduleUnit.Monthly)
-                    throw new InvalidOperationException(S._("The ScheduleUnit of the schedule does " +
-                        "not require the MonthlySchedule value, this field would contain garbage"));
+                    throw new InvalidOperationException("The ScheduleUnit of the schedule does " +
+                        "not require the MonthlySchedule value, this field would contain garbage");
 
                 return monthlySchedule;
@@ -470 +470 @@
         {
             if (ScheduleType != RecurringScheduleUnit.Weekly)
-                throw new ArgumentException(S._("The ScheduleUnit of the schedule does " +
-                    "not use the WeeklySchedule value, this field would contain garbage"));
+                throw new ArgumentException("The ScheduleUnit of the schedule does " +
+                    "not use the WeeklySchedule value, this field would contain garbage");
             return ((int)weeklySchedule & (1 << (int)date.DayOfWeek)) != 0;
         }