Changeset 1768 for branches/eraser6/CodeReview/Eraser/SettingsPanel.cs

Timestamp:

2/8/2010 7:20:53 AM (2 years ago)

Author:

lowjoel

Message:

Also specify MessageBoxOptions?.RightAlign? if the dialog which owns the message box is RTL-reading. addresses #275: Code Review

File:

• branches/eraser6/CodeReview/Eraser/SettingsPanel.cs (modified) (5 diffs)

branches/eraser6/CodeReview/Eraser/SettingsPanel.cs

@@ -243 +243 @@
                     defaults), S._("Eraser"), MessageBoxButtons.OK, MessageBoxIcon.Warning,
                     MessageBoxDefaultButton.Button1,
-                    S.IsRightToLeft(this) ? MessageBoxOptions.RtlReading : 0);
+                    S.IsRightToLeft(this) ?
+                        MessageBoxOptions.RtlReading | MessageBoxOptions.RightAlign : 0);
                 saveSettings_Click(null, null);
             }
@@ -286 +287 @@
                 MessageBox.Show(this, S._("The path you selected is invalid."), S._("Eraser"),
                     MessageBoxButtons.OK, MessageBoxIcon.Error, MessageBoxDefaultButton.Button1,
-                    S.IsRightToLeft(this) ? MessageBoxOptions.RtlReading : 0);
+                    S.IsRightToLeft(this) ?
+                        MessageBoxOptions.RtlReading | MessageBoxOptions.RightAlign : 0);
             }
         }
@@ -367 +369 @@
                     "the next time Eraser is started."), S._("Eraser"), MessageBoxButtons.OK,
                     MessageBoxIcon.Information, MessageBoxDefaultButton.Button1,
-                    S.IsRightToLeft(this) ? MessageBoxOptions.RtlReading : 0);
+                    S.IsRightToLeft(this) ?
+                        MessageBoxOptions.RtlReading | MessageBoxOptions.RightAlign : 0);
             }
 
@@ -409 +412 @@
                     "Eraser is restarted."), S._("Eraser"), MessageBoxButtons.OK,
                     MessageBoxIcon.Information, MessageBoxDefaultButton.Button1,
-                    S.IsRightToLeft(this) ? MessageBoxOptions.RtlReading : 0);
+                    S.IsRightToLeft(this) ?
+                        MessageBoxOptions.RtlReading | MessageBoxOptions.RightAlign : 0);
             }
             settings.IntegrateWithShell = uiContextMenu.Checked;
@@ -425 +429 @@
                     S._("Eraser"), MessageBoxButtons.OK, MessageBoxIcon.Information,
                     MessageBoxDefaultButton.Button1,
-                    S.IsRightToLeft(this) ? MessageBoxOptions.RtlReading : 0);
+                    S.IsRightToLeft(this) ?
+                        MessageBoxOptions.RtlReading | MessageBoxOptions.RightAlign : 0);
                 managerSettings.ActivePrng = newPRNG.Guid;
             }