Changeset 569 for branches/eraser6/Eraser/SettingsPanel.cs

Timestamp:

11/14/2008 2:14:26 PM (4 years ago)

Author:

lowjoel

Message:

Tighten the plugin loading criteria:
-Plugins are first loaded reflection-only, checking for the presence of the IPlugin interface being implemented. If it is not implemented, the DLL is skipped.
-The plugins are then checked for a public key. If the public key is different from the executing assembly, it is not trusted and therefore is foreign.
-Foreign plugins must be approved by the user explicitly before they are loaded.

The SettingsPanel? and the ManagerSettings? classes have therefore been updated.

File:

• branches/eraser6/Eraser/SettingsPanel.cs (modified) (3 diffs)

branches/eraser6/Eraser/SettingsPanel.cs

@@ -59 +59 @@
         private void OnNewPluginLoaded(PluginInstance instance)
         {
-            ListViewItem item = pluginsManager.Items.Add(instance.Plugin.Name);
-            item.SubItems.Add(instance.Plugin.Author);
+            ListViewItem item = new ListViewItem();
+            if (instance.Plugin == null)
+            {
+                item.Text = System.IO.Path.GetFileNameWithoutExtension(instance.Assembly.Location);
+                item.SubItems.Add(instance.AssemblyInfo.Author);
+            }
+            else
+            {
+                item.Text = instance.Plugin.Name;
+                item.SubItems.Add(instance.Plugin.Author);
+            }
+
+            item.Checked = instance.Plugin != null ||
+                Manager.ManagerLibrary.Instance.Settings.ApprovedPlugins.IndexOf(
+                    instance.AssemblyInfo.GUID) != -1;
             item.SubItems.Add(instance.Assembly.GetName().Version.ToString());
-            item.SubItems.Add(instance.Path);
+            item.SubItems.Add(instance.Assembly.Location);
             item.Tag = instance;
+            pluginsManager.Items.Add(item);
         }
 
@@ -340 +354 @@
 
             EraserSettings settings = new EraserSettings();
+            ManagerSettings managerSettings = ManagerLibrary.Instance.Settings;
             if (((Language)uiLanguage.SelectedItem).Name != settings.Language)
             {
@@ -346 +361 @@
                     S._("Eraser"), MessageBoxButtons.OK, MessageBoxIcon.Information);
             }
-            ManagerLibrary.Instance.Settings.DefaultFileErasureMethod =
+            managerSettings.DefaultFileErasureMethod =
                 ((ErasureMethod)eraseFilesMethod.SelectedItem).GUID;
-            ManagerLibrary.Instance.Settings.DefaultUnusedSpaceErasureMethod =
+            managerSettings.DefaultUnusedSpaceErasureMethod =
                 ((ErasureMethod)eraseUnusedMethod.SelectedItem).GUID;
 
             PRNG newPRNG = (PRNG)erasePRNG.SelectedItem;
-            if (newPRNG.GUID != ManagerLibrary.Instance.Settings.ActivePRNG)
+            if (newPRNG.GUID != managerSettings.ActivePRNG)
             {
                 MessageBox.Show(S._("The new randomness data source will only be used when " +
                     "the next task is run.\nCurrently running tasks will use the old source."),
                     S._("Eraser"), MessageBoxButtons.OK, MessageBoxIcon.Information);
-                ManagerLibrary.Instance.Settings.ActivePRNG = newPRNG.GUID;
-            }
-            ManagerLibrary.Instance.Settings.EraseLockedFilesOnRestart =
-                lockedAllow.Checked;
-            ManagerLibrary.Instance.Settings.ConfirmEraseOnRestart =
-                lockedConfirm.Checked;
-
+                managerSettings.ActivePRNG = newPRNG.GUID;
+            }
+            managerSettings.EraseLockedFilesOnRestart = lockedAllow.Checked;
+            managerSettings.ConfirmEraseOnRestart = lockedConfirm.Checked;
+
+            managerSettings.PlausibleDeniability = plausibleDeniability.Checked;
             List<string> plausibleDeniabilityFilesList = new List<string>();
             foreach (string str in this.plausibleDeniabilityFiles.Items)
                 plausibleDeniabilityFilesList.Add(str);
-            ManagerLibrary.Instance.Settings.PlausibleDeniabilityFiles = plausibleDeniabilityFilesList;
-
-            ManagerLibrary.Instance.Settings.ExecuteMissedTasksImmediately =
-                schedulerMissedImmediate.Checked;
-            ManagerLibrary.Instance.Settings.PlausibleDeniability =
-                plausibleDeniability.Checked;
+            managerSettings.PlausibleDeniabilityFiles = plausibleDeniabilityFilesList;
+
+            managerSettings.ExecuteMissedTasksImmediately = schedulerMissedImmediate.Checked;
+
+            foreach (ListViewItem item in pluginsManager.Items)
+            {
+                PluginInstance plugin = (PluginInstance)item.Tag;
+                if (item.Checked)
+                {
+                    if (managerSettings.ApprovedPlugins.IndexOf(plugin.AssemblyInfo.GUID) == -1)
+                        managerSettings.ApprovedPlugins.Add(plugin.AssemblyInfo.GUID);
+                }
+                else
+                    managerSettings.ApprovedPlugins.Remove(plugin.AssemblyInfo.GUID);
+            }
         }
     }