Ticket #363 (closed enhancement: fixed)

Opened 5 years ago

Last modified 3 years ago

Plugin Code Review

Reported by: Joel Owned by: Joel
Priority: critical Milestone: Eraser 6.1/6.2
Component: Core Version:
Keywords: Cc:
Processor Architecture: Blocked By:
Blocking: #70, #147 Operating System:

Description (last modified by Joel) (diff)

  • Plugins should have a glue library that doesn't change, like a runtime for plugins that all plugins depend on (instead of a specific Eraser.Manager version)
  • There should be a Tools menu for plugins to include themselves
  • Plugins should have alternative methods of declaring themselves as Core -- since Core plugins can't be disabled, these are plugins which are referenced directly within Eraser
  • Change the PluginInstance class to the PluginInfo? class

Blocking

IdSummaryMilestone
#363Plugin Code ReviewEraser 6.1/6.2
#147Ballast File Creation.Eraser 6.1/6.2
#70Cleaning up of privacy leaksEraser 6.1/6.2

Blocked by

IdSummaryMilestone
#363Plugin Code ReviewEraser 6.1/6.2

Change History

comment:1 Changed 5 years ago by Joel

  • Status changed from new to accepted
  • Owner set to Joel
  • Description modified (diff)

comment:2 Changed 5 years ago by Joel

  • Description modified (diff)

Fixed in r2050.

Core plugins can now only be defined in the loading library (Eraser.Manager.dll) and the Loading Policy attribute is ignored if it is set as core, regardless of Authenticode signature and Strong Name key.

comment:3 Changed 4 years ago by Joel

  • Blocking 147 added

comment:4 Changed 4 years ago by Joel

  • Blocking 70 added

comment:5 Changed 4 years ago by Joel

  • Description modified (diff)

PluginInstance? class was renamed to the PluginInfo? class in r2293

comment:6 Changed 3 years ago by Joel

  • Description modified (diff)

With r2501, the plugins rewrite branch depends on the Eraser.Plugins assembly which only contains interfaces for plugins to implement. Version for that will be kept constant unless there is an API change (r2502).

comment:7 Changed 3 years ago by Joel

  • Description modified (diff)

Implemented in r2503-r2506.

Seems like we are done with this ticket!

comment:8 Changed 3 years ago by Joel

  • Status changed from accepted to closed
  • Resolution set to fixed

Commited in r2509. Branch deleted in r2510.

Note: See TracTickets for help on using tickets.