Context Navigation

-When using ToString? pass the current culture, and when using string.Format specify the current culture.
-When using MessageBox?.Show, tell it to display the dialog RTL when the parent control is in RTL mode.

12:30 Changeset [908] by lowjoel

branches/eraser6/DefaultPlugins/CustomMethodEditorForm.Designer.cs
branches/eraser6/DefaultPlugins/CustomMethodEditorForm.cs
branches/eraser6/DefaultPlugins/CustomMethodPassEditor.cs
branches/eraser6/DefaultPlugins/EraseCustom.cs
branches/eraser6/DefaultPlugins/Plugin.cs
branches/eraser6/DefaultPlugins/RNGCrypto.cs
branches/eraser6/DefaultPlugins/SettingsForm.cs

Ran static code analysis on DefaultPlugin?

-Use proper casing for abbreviations
-Enumeration values should be camel casing
-public Enumeration types should be outside the class
-Don't initialise members to default values
-Make GetObjectData? overridable
-Implement the Dispose pattern properly

12:16 Changeset [907] by lowjoel

branches/eraser6/Eraser/Strings.NL.resx
branches/eraser6/Eraser/Strings.en.resx
branches/eraser6/Eraser/Strings.resx

Updated string for the task list serialisation exception.

12:15 Changeset [906] by lowjoel

branches/eraser6/Eraser/SchedulerPanel.cs

No need to use P/Invoke to get the bounds of a listview subitem. Use the .NET API instead.

12:13 Changeset [905] by lowjoel

branches/eraser6/DefaultPlugins/EraseCustom.cs
branches/eraser6/DefaultPlugins/EraseDoD.cs
branches/eraser6/DefaultPlugins/EraseFirstLast16KB.cs
branches/eraser6/DefaultPlugins/EraseGOSTP50739.cs
branches/eraser6/DefaultPlugins/EraseGutmann.cs
branches/eraser6/DefaultPlugins/EraseHMGIS5.cs
branches/eraser6/DefaultPlugins/EraseRCMP_TSSIT_OPS_II.cs
branches/eraser6/DefaultPlugins/EraseRandom.cs
branches/eraser6/DefaultPlugins/EraseSchneier.cs
branches/eraser6/DefaultPlugins/EraseUSAF5020.cs
branches/eraser6/DefaultPlugins/EraseUSArmyAR380_19.cs
branches/eraser6/DefaultPlugins/EraseVSITR.cs
branches/eraser6/DefaultPlugins/Plugin.cs
branches/eraser6/DefaultPlugins/RNGCrypto.cs
branches/eraser6/DefaultPlugins/RNGISAAC.cs
branches/eraser6/DefaultPlugins/SettingsForm.cs
branches/eraser6/Eraser/LogForm.cs
branches/eraser6/Eraser/MainForm.cs
branches/eraser6/Eraser/Program.cs
branches/eraser6/Eraser/ProgressForm.cs
branches/eraser6/Eraser/SettingsPanel.cs
branches/eraser6/Eraser/TaskDataSelectionForm.cs
branches/eraser6/Eraser/TaskPropertiesForm.cs
branches/eraser6/Manager/DirectExecutor.cs
branches/eraser6/Manager/EntropySource.cs
branches/eraser6/Manager/Executor.cs
branches/eraser6/Manager/FileSystem.cs
branches/eraser6/Manager/Language.cs
branches/eraser6/Manager/Logger.cs
branches/eraser6/Manager/Manager.cs
branches/eraser6/Manager/Method.cs
branches/eraser6/Manager/PRNG.cs
branches/eraser6/Manager/Plugins.cs
branches/eraser6/Manager/RemoteExecutor.cs
branches/eraser6/Manager/Schedule.cs
branches/eraser6/Manager/Settings.cs
branches/eraser6/Manager/Task.cs

Ran static code analysis on Manager.

-Do not initialise class members to default values (runtime will handle that)
-Deserialisation constructors should be marked protected for unsealed classes
-Classes implementing ICollection should end with Collection (Mainly fixed here is ErasureTargetsCollection?)
-ISerializable.GetObjectData? should be marked virtual
-Use proper camel casing (Prng, Guid, FileName? etc)
-Enumeration values should be Camel casing
-Bitfields should be marked with the [Flags] attribute
-Implement the proper IDisposable pattern - one Dispose() and one Dispose(bool) - the latter doing the clean ups for both Dispose and finalisers
-public variables should instead be properties
-Abstract classes should have protected constructors
-Renamed Schedule.Type to Schedule.ScheduleType? to prevent ambiguity with GetType?()
-There shouldn't be a need to pass reference variables by reference

10:38 Changeset [904] by lowjoel

branches/eraser6/Eraser/BasePanel.Designer.cs
branches/eraser6/Eraser/BasePanel.resx
branches/eraser6/Eraser/MainForm.Designer.cs
branches/eraser6/Eraser/MainForm.cs
branches/eraser6/Eraser/MainForm.resx
branches/eraser6/Eraser/SchedulerPanel.Designer.cs
branches/eraser6/Eraser/SettingsPanel.Designer.cs

Ran Static code analysis on the Eraser project and implemented a few recommendations.

-Variable references should not use abbreviations of things: lbl should be expanded to Label
-Fixed "minimise" to "minimised"
-Enumeration constants should be in CamelCase

10:34 Changeset [903] by lowjoel

branches/eraser6/Eraser/AboutForm.Designer.cs
branches/eraser6/Eraser/AboutForm.cs
branches/eraser6/Eraser/LogForm.cs
branches/eraser6/Eraser/Program.cs
branches/eraser6/Eraser/TaskDataSelectionForm.cs
branches/eraser6/Eraser/TaskPropertiesForm.cs
branches/eraser6/Eraser/ToolBar.cs
branches/eraser6/Eraser/UpdateForm.cs

Ran Static code analysis on the Eraser project and implemented a few recommendations.

-Use more specific exceptions to allow code to determine the type of exception.
-Made GUIProgram implement IDisposable since the global mutex must be freed.
-Mde AboutForm? implement IDisposable, clearing the caching bitmaps on dispose.
-Made a few CommandLineProgram? functions static since they don't reference this.
-Name parameters/local with more unique, descriptive names for clarity.
-Use EventHandler?<EventArg?> instead of declaring our own delegate and event types as the type of the evenr handler

08:12 Changeset [902] by lowjoel

branches/eraser6/Manager/FileSystem.cs

Added extra newlines to make the code fit within 100 characters per line

08:11 Changeset [901] by lowjoel

branches/eraser6/Manager/Strings.en.resx
branches/eraser6/Manager/Strings.nl.resx
branches/eraser6/Manager/Strings.resx

Added a few missing strings.

08:01 Changeset [900] by lowjoel

branches/eraser6/Eraser/LogForm.cs
branches/eraser6/Eraser/LogForm.resx

Allow long logs to be displayed rapidly by disabling redrawing until all items are added.

07:54 Changeset [899] by lowjoel

branches/eraser6/Manager/DirectExecutor.cs
branches/eraser6/Manager/Executor.cs
branches/eraser6/Manager/FileSystem.cs
branches/eraser6/Manager/Manager.csproj

Refactored out the filesystem-specific code from DirectExecutor? to a FileSystem? class. Currently only implemented for NTFS

07:42 Changeset [898] by lowjoel

branches/eraser6/Manager/DirectExecutor.cs
branches/eraser6/Manager/Task.cs

Stylistic corrections: use internal set in properties instead of using interally-visible member variables

4/27/2009:

13:43 Ticket #179 (Right Click Recycle Bin Failure) closed by Joel

duplicate: Actually, duplicated under #195.

13:40 Ticket #161 (Weekly schedule not working) closed by Joel

invalid: Ah I know why. This is because the scheduler lets you select multiple days …

13:24 Changeset [897] by lowjoel

branches/eraser6/DefaultPlugins/DefaultPlugins.csproj
branches/eraser6/Installer/Installer.wixproj

Get the Authenticode signatures from the system certificate store.

13:17 Ticket #139 (Right clicking recycle bin two errors.) closed by Joel

fixed: Oops, wrong ticket.

13:16 Ticket #173 (Odd Progress Bar Result.) closed by Joel

fixed: Fixed in r896

13:16 Changeset [896] by lowjoel

branches/eraser6/Eraser/Eraser.csproj
branches/eraser6/Eraser/ProgressForm.cs
branches/eraser6/Eraser/ProgressForm.en.resx
branches/eraser6/Eraser/ProgressForm.resx
branches/eraser6/Eraser/Strings.NL.resx
branches/eraser6/Eraser/Strings.en.resx
branches/eraser6/Eraser/Strings.resx

Implemented a more generic message when the dialog containing the progress of the erase is shown, so that the user will know that he has to wait for progress information to come from the executor. Fix for #173.

13:09 Ticket #173 (Odd Progress Bar Result.) reopened by Joel

13:06 Ticket #177 (Erasing file in use, no error message.) closed by Joel

fixed: I tried erasing a directory of symbol files which were locked; Eraser …

13:00 Ticket #139 (Right clicking recycle bin two errors.) reopened by Joel

Then again, I think we can replace the labels on the dialog to make it …

13:00 Ticket #173 (Odd Progress Bar Result.) closed by Joel

wontfix: I can't think of any way to solve this (even after so many months). This …

12:54 Ticket #139 (Right clicking recycle bin two errors.) closed by Joel

fixed: Okay, so the recycle bin icon should have been fixed and the only problem …

12:49 Changeset [895] by lowjoel

branches/eraser6/Eraser/Eraser.csproj
branches/eraser6/Util/File.cs

Using FileInfo?.OpenRead? will cause a file to be locked. In our case, the file doesn't need to be locked so open a file handle, allowing other applications to share access. This handles locked files better in tasks.

12:46 Changeset [894] by lowjoel

branches/eraser6/Manager/DirectExecutor.cs
branches/eraser6/Manager/Strings.en.resx
branches/eraser6/Manager/Strings.nl.resx
branches/eraser6/Manager/Strings.resx

-Handle files which are currently locked by another process - currently the behaviour is to log the file as unerased and flag the task as an error having occurred
-Handle sparse/compressed/encrypted files without throwing an exception because that will cause the rest of the files to remain unerased

11:47 Ticket #171 (Disable buffering) closed by Joel

fixed: Actually I've looked through the documentation again and …

11:47 Changeset [893] by lowjoel

branches/eraser6/Manager/DirectExecutor.cs

Don't allow file writes to stay in the system cache for later writing - instruct that data be written to disk immediately. Fixes #171.

4/26/2009:

23:59 Changeset [892] by lowjoel

branches/eraser6/Installer/SignBin.bat

Store all certificates in the Windows certificate store instead of having thme as loose pfx's on the disk for security reasons.

11:44 Changeset [891] by lowjoel

trunk/bin/Eraser.iss

Delete user configuration files after uninstall.

4/22/2009:

07:21 Ticket #175 (Schedule screen won’t clear properly.) closed by Joel: worksforme: No repro case again... I really can't see how or why that will happen.
07:12 Ticket #180 (Flash Drive Error.) closed by Joel: worksforme: Can't replicate the thing. Also, I remembered fixing a similar problem …

4/19/2009:

10:16 Changeset [890] by lowjoel

branches/website/announcements/20090418.html

Fixed the hahes. Also, display hashes in a code block for clarity.

10:15 Changeset [889] by lowjoel

branches/website/index.php

Use standard terminology - the Portable version not the Standalone version.

4/18/2009:

23:30 Ticket #183 (Capcha too hard or not working.) closed by Joel

invalid: Actually on the forum the captcha is standard and comes packaged with …

17:40 Ticket #112 (Slow authentication e-mail) closed by Garrett

fixed: This may be due to mail server overloaded and is transient.

17:38 Ticket #143 (ISSAC or ISSAC+) closed by Garrett

fixed: Having a totally random generator will actually make it easier for a …

04:59 Changeset [888] by lowjoel

branches/website/Templates/Eraser.dwt
branches/website/announcements/20081201.html
branches/website/announcements/20081213.html
branches/website/announcements/20090103.html
branches/website/announcements/20090108.html
branches/website/announcements/20090418.html
branches/website/contributing.html
branches/website/index.php
branches/website/reviews.html

Aded the announcement for 5.8.7beta5

04:38 Changeset [887] by lowjoel

trunk/README.txt
trunk/version.h

Version bump.

03:59 Ticket #205 (VS x64 libraries redistributable installer fails to install) closed by Joel

fixed: Fixed in r886. I kinda forgot that both the x64 and x86 builds can be …

03:58 Changeset [886] by lowjoel

trunk/bin/Eraser.iss

Extract the 32-bit and 64-bit VC++ redistributables if WoW was selected. Fixes #205

03:52 Ticket #134 (Vista 64 Eraser v5.87 no context menu) closed by Joel

fixed: Thanks, fixed in r885. Was a typo in the setup script.

03:51 Changeset [885] by lowjoel

trunk/bin/Eraser.iss

Fixed missing shell extension. Fixes #134.

02:22 Changeset [884] by lowjoel

trunk/EraserDll/Eraser.cpp
trunk/EraserDll/File.cpp
trunk/EraserDll/Random.cpp
trunk/EraserDll/Random.h
trunk/EraserDll/Schneier7Pass.cpp
trunk/SchedulerView.cpp

-Fixed a few 64-bit warnings
-Fixed a wrong use of assignment operator (== was intended)
-Corrected the ISAAC code for 64-bit, buffers were assumed to be long enough onlt to fit in a 32-bit integer

4/17/2009:

11:48 Changeset [883] by lowjoel

trunk/Eraser.cpp
trunk/SchedulerView.cpp
trunk/StdAfx.h

Fixed the next-run time column for tasks which run at midnight.

11:47 Changeset [882] by lowjoel

trunk/Item.cpp
trunk/SchedulerView.cpp

Implemented the task-end action for scheduled tasks and dragged and dropped on-demand tasks

07:05 Ticket #30 (Encrypted page file) closed by Joel

wontfix: Hmm, agreed.

07:01 Ticket #199 (Scheduler Next Run does not show time if set to midnight) closed by Joel

fixed: Fixed in r883

06:44 Ticket #185 (The "COPYING.txt" file is corrupted.) closed by Joel

wontfix

06:41 Ticket #198 (When Finished option does not work for Scheduled Tasks) closed by Joel

fixed: Ok I've really fixed it in r882. Also fixed the drag and drop problem and …

06:07 Ticket #189 (Eraser shutting down entire system) closed by Joel

duplicate: Main problem is #198. Will close this as duplicate.

06:06 Ticket #190 (Eraser setting up unwanted entry in autostart for deletion) closed by Joel

wontfix: I think the first problem you raised can't be fixed. If the user says the …

4/13/2009:

19:23 Ticket #205 (VS x64 libraries redistributable installer fails to install) created by Walda: It can't find a cab in the user's temp folder. […] It's really not …
19:18 Ticket #134 (Vista 64 Eraser v5.87 no context menu) reopened by Walda: Confirmed, no context menu in Vista x64. Using 5.87 beta 4. Version …

4/12/2009:

02:27 Ticket #204 (Add a non admin restore to delete utility for unused space) created by donald: Add a non admin restore to delete utility for unused space. By this I …

3/29/2009:

08:00 Ticket #196 (Website: Give easy access to old announcements) closed by trac-robot: This ticket was closed automatically by the system. It was previously set …
08:00 Ticket #178 (Eraser Calculating Time.) closed by trac-robot: This ticket was closed automatically by the system. It was previously set …

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed